Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test utils exportable #289

Merged
merged 13 commits into from
Dec 3, 2024
Merged

Make test utils exportable #289

merged 13 commits into from
Dec 3, 2024

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Nov 26, 2024 •
edited
Loading

What

This PR makes following changes:

  • Move the common test utils functions to its file
  • Capitalize function names/var names for test utils

Why

To make these functions exportable across modules

Known limitations

None

@amishas157 amishas157 marked this pull request as ready for review December 3, 2024 19:56
@amishas157 amishas157 requested a review from a team as a code owner December 3, 2024 19:56
@amishas157 amishas157 changed the title export cmd utils Make test utils exportable Dec 3, 2024
@amishas157 amishas157 merged commit 53929d8 into master Dec 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chowbao chowbao chowbao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amishas157 @chowbao